Added a Kotlin section in CONTRIBUTING.md #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core team does not want to convert to Kotlin yet and sees Java as the easier to learn and more well adopted language. This stance might of course change in the future. For example it could be reasonable to do a complete transition to Kotlin once it is decides that the minSdk is raised to 21 or higher, as we then could use Jetpack particularly Lifecycle and Compose.
triallax
reviewed
Jul 14, 2021
|
I agree with the point made on IRC that just simply converting classes to kotlin in not valueable. I would go even further and say it's harmfull, because nearly no part is covered by tests. So these changes rely on use trusting the contributor or on the time of the reviewer to verify that no bugs are introduced. Whats missing for me is the stance on new classes. |
|
@mhmdanas |
triallax
approved these changes
Jul 17, 2021
5 tasks
Stypox
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Core team does not want to convert to Kotlin yet and sees Java as the easier to learn and more well adopted language.
This stance might of course change in the future. For example it could be reasonable to do a complete transition to Kotlin once it is decided that the minSdk is raised to 21 or higher, as we then could use Jetpack particularly Lifecycle and Compose.
Due diligence