Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compileSdkVersion to 30. #6654

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Bump the compileSdkVersion to 30.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. This can now be done since SAF is correctly supported, or am I wrong? @B0pol @TobiGr

@TobiGr
Copy link
Member

TobiGr commented Jul 18, 2021

This should be good to go. However, I'd postpone this until SAF can be used without crashes like #6667

@Stypox
Copy link
Member

Stypox commented Jul 18, 2021

@TobiGr the problem in #6667 is not related to SAF but just to dialog lifecycle

@Stypox Stypox merged commit 3167ab3 into TeamNewPipe:dev Jul 19, 2021
@Isira-Seneviratne Isira-Seneviratne deleted the Bump_compileSdk branch July 19, 2021 14:16
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants