Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GestureDetectorCompat. #6637

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 10, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use GestureDetectorCompat to backport GestureDetector improvements to Android versions below 4.3, allowing this change to be used in NewPipe Legacy.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Jul 10, 2021
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Jul 10, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and this is the correct change by looking up online. Thank you :-D

@Stypox Stypox merged commit a932bc2 into TeamNewPipe:dev Jul 17, 2021
@Isira-Seneviratne Isira-Seneviratne deleted the Use_GestureDetectorCompat branch July 18, 2021 02:14
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants