Use PackageInfoCompat.getSignatures(). #6634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
the
codequality
|
I don't know if bumping the compileSdk from 29 to 30 can be done yet. Developer thoughts? |
|
If it can be done, it should be done seperatly and not packaged together like this |
Isira-Seneviratne
force-pushed
the
Use_PackageInfoCompat
branch
3 times, most recently
from
edb3173
to
33e0350
Compare
5 tasks
Isira-Seneviratne
force-pushed
the
Use_PackageInfoCompat
branch
from
33e0350
to
9458b9f
Compare
|
Any updates on this? |
|
Yeah, I moved the compileSdk bump to another PR a while ago. |
|
@Isira-Seneviratne Lol I meant from the team members. This seems good to go, as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
PackageInfoCompat.getSignaturesto get the app signatures.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence