Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the thumbnail in the minimized player visible again #6616

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented Jul 6, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Before/After Screenshots/Screen Record

  • Before:
    grafik
  • After:
    grafik

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@AudricV AudricV added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Jul 7, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works. Thanks :-D

@TobiGr
Copy link
Member

TobiGr commented Jul 8, 2021

@litetex Thank you for this PR and the ones you opened in the last weeks. We are happy about your contributions. We'd like to invite you to join the team. If you want, you can accept the invitation I just sent to you.

@litetex
Copy link
Member Author

litetex commented Jul 8, 2021

@TobiGr
Thank you for the invitation. I already gladly accepted it 😄
To a good cooperation 🍾

@opusforlife2
Copy link
Collaborator

@litetex Please join us on the Newpipe channel: https://matrix.to/#/#newpipe:libera.chat

@TobiGr TobiGr merged commit 64efb89 into TeamNewPipe:dev Jul 12, 2021
@litetex litetex deleted the fix-minimized-player-thumbnail branch July 12, 2021 19:04
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimized player thumbnail is completely black/white
5 participants