Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify emulator-build version in CI job #6560

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Specify emulator-build version in CI job #6560

merged 1 commit into from
Jul 12, 2021

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Jun 23, 2021

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

Fixes the following issue(s)

All actions for instrumented tests fail due to emulator not starting properly

/Users/runner/Library/Android/sdk/platform-tools/adb shell getprop sys.boot_completed
adb: no devices/emulators found
The process '/Users/runner/Library/Android/sdk/platform-tools/adb' failed with exit code 1
Error: The operation was canceled.

Due diligence

@XiangRongLin XiangRongLin added the bug Issue is related to a bug label Jun 23, 2021
@XiangRongLin XiangRongLin marked this pull request as draft June 23, 2021 16:05
@XiangRongLin XiangRongLin changed the title Use macos-11 to avoid emulator timeout Specify emulator-build version in CI job Jul 6, 2021
@XiangRongLin XiangRongLin marked this pull request as ready for review July 6, 2021 15:00
@XiangRongLin XiangRongLin requested a review from Stypox July 6, 2021 15:00
@Stypox
Copy link
Member

Stypox commented Jul 7, 2021

I don't feel like I know enough to review this, sorry

@XiangRongLin
Copy link
Collaborator Author

@Stypox Who does then? With that mindset I think no one can review this

This PR only adds emulator-build: 7425822, which comes from the linked issue

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who does then? With that mindset I think no one can review this

Mmmh ok, sorry. By looking at the issue you linked it seems like this should work, so I'm approving it, though I really do not know much about the CI.

@TobiGr TobiGr merged commit 4d5b687 into dev Jul 12, 2021
@TobiGr TobiGr deleted the fix_ci_emulator branch July 12, 2021 14:16
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants