Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some libraries #6540

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Update some libraries #6540

merged 1 commit into from
Jul 12, 2021

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@XiangRongLin
Copy link
Collaborator

Seeing that there are new bugs introduces with library bumps #6522, how is it ensured that these bumps don't cause similiar issues?

@XiangRongLin XiangRongLin added the codequality Improvements to the codebase to improve the code quality label Jun 21, 2021
@TacoTheDank
Copy link
Member Author

@XiangRongLin AndroidX Fragment is a rather important infrastructure library used in lots of places throughout the project, while the libraries updated here are of much less importance and are used in only a couple places. So, there is a miniscule chance these could cause anything. Also, I went through and checked the changes in the library code to see if anything stood out, and there was nothing worthwhile to note.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are safe with this. I tested Markwon by opening the "What is peertube?" video on Framasoft, which contains a Markdown description (not testable on API 19 since Peertube does not work there because of missing certificates). I tested Stetho by inspecting the app in Chromium and it shows the same behaviour as before the update after clicking on inspect (even though I don't understand how it works). I tested the player and it works (this involves the media library). I tested the error activity and it works (this involves google auto). I tested on both API 19 emulated and API 29 real.

@TobiGr TobiGr merged commit 85d813a into TeamNewPipe:dev Jul 12, 2021
@TacoTheDank TacoTheDank deleted the library-bumps branch July 12, 2021 14:18
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants