Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle #6538

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Bump gradle #6538

merged 2 commits into from
Jul 12, 2021

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Jun 20, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

1st commit

  • Add mavenCentral and de-prioritize jcenter (to make the project use mavenCentral first)
  • Update groupie's artifact names (see here)

2nd commit

  • Update buildTools 29.0.3 -> 30.0.3
  • Update Android Gradle Plugin 4.1.3 -> 4.2.1 4.2.2
  • Update Gradle 6.8.3 -> 7.1 7.1.1 (using git bash)
  • Fix a bunch of Gradle-related deprecations (existing and new)

Fixes the following issue(s)

  • Fixes using old versions, gets us closer to removing jcenter :) (only one (1) library stands in the way: ExoPlayer)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@jimman2003
Copy link
Contributor

jimman2003 commented Jun 21, 2021

If you add google() (google maven repo) you may be able to get rid of jcenter see:https://github.com/google/ExoPlayer#using-exoplayer
allprojects { repositories { google() ...}}}
Edit: Out of Scope..

@XiangRongLin XiangRongLin added the codequality Improvements to the codebase to improve the code quality label Jun 21, 2021
@TobiGr
Copy link
Member

TobiGr commented Jun 21, 2021

If you add google() (google maven repo) you may be able to get rid of jcenter see:https://github.com/google/ExoPlayer#using-exoplayer
allprojects { repositories { google() ...}}}

Not in this PR, see #5843

Stypox
Stypox previously approved these changes Jul 5, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tried building on my PC and everything went well. I tested the app on API 19 emulated and my API 29 phone and there were no issues whatsoever.

@TacoTheDank
Copy link
Member Author

@Stypox Thanks! Also, I repushed the last commit to update Android Studio to 4.2.2, as well as Gradle to 7.1.1. Feel free to test it again if you wish, although it shouldn't affect anything at all :)

@AudricV AudricV mentioned this pull request Jul 10, 2021
5 tasks
@TobiGr TobiGr merged commit e9b008e into TeamNewPipe:dev Jul 12, 2021
@TacoTheDank TacoTheDank deleted the bump-gradle branch July 12, 2021 14:16
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants