Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More onActivityResult deprecation fixes #6536

Merged
merged 4 commits into from
Jul 18, 2021
Merged

More onActivityResult deprecation fixes #6536

merged 4 commits into from
Jul 18, 2021

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • This is the second of what will most likely be a trilogy of PRs for fixing the onActivityResult/onRequestPermissionsResult deprecations (the stuff dealing with the ReCaptcha result stuff will be the third PR)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Jun 20, 2021
@TacoTheDank
Copy link
Member Author

Any updates?

Stypox
Stypox approved these changes Jul 18, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I also tested and everything works fine. Thank you :-D

@Stypox Stypox merged commit baa12c7 into TeamNewPipe:dev Jul 18, 2021
@Stypox Stypox mentioned this pull request Jul 20, 2021
Merged
@TacoTheDank TacoTheDank deleted the moar-onactivityresult branch July 20, 2021 17:57
@TacoTheDank TacoTheDank mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TacoTheDank @Stypox @triallax