Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate some overridden methods and parameters as NonNull #6528

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Annotate some overridden methods and parameters as NonNull #6528

merged 1 commit into from
Jun 20, 2021

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixes some Not annotated [parameter/method] overrides @NonNull parameter lints.

Fixes the following issue(s)

  • Probably nothing but it's just for safety.

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Jun 19, 2021
@XiangRongLin XiangRongLin changed the title Annotate some overridden methods and parameters Annotate some overridden methods and parameters as NonNull Jun 20, 2021
@B0pol B0pol merged commit 6c57551 into TeamNewPipe:dev Jun 20, 2021
@TacoTheDank TacoTheDank deleted the annotate-methods branch June 20, 2021 17:46
This was referenced Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants