dismiss choice dialog in onStop() to avoid a leaked window Exception: #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E/WindowManager: android.view.WindowLeaked: Activity org.schabi.newpipe.RouterActivity has leaked window DecorView@d99fe3b[] that was originally added here
at android.view.ViewRootImpl.<init>(ViewRootImpl.java:418)
Redirion
reviewed
Jun 17, 2021
| @@ -126,6 +127,15 @@ protected void onCreate(final Bundle savedInstanceState) { | |||
| ? R.style.RouterActivityThemeLight : R.style.RouterActivityThemeDark); | |||
| } | |||
|
|
|||
| @Override | |||
| protected void onStop() { | |||
There was a problem hiding this comment.
is there any reason why you decided to use onStop in favor of onPause? I think it could also be put there to be cleared up as early as possible
There was a problem hiding this comment.
the reason is as @Stypox stated.
Stypox
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
@Redirion It looks good in my opinion, since onStop is called once when the activity is being shut down completely, while onPause may be also called for other reasons (e.g. user turned off the screen, but that shouldn't dismiss dialogs). Thank you @evermind-zz :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E/WindowManager: android.view.WindowLeaked: Activity org.schabi.newpipe.RouterActivity has leaked window DecorView@d99fe3b[] that was originally added here
at android.view.ViewRootImpl.(ViewRootImpl.java:418)
What is it?
Description of the changes in your PR
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence