Replace the System.exit calls with getActivity.finishAffinity()

[danielmbutler]

Replaced System.exit call with finishAffinity() and start MainActivity call, tested by changing some settings values, exporting my configuration, reversing the changes, and then reimporting the settings, once the MainActivity was restarted I could then see my chosen settings imported.

Also updated ExitActivity.java to remove System.Exit call and replace with start MainActivity

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Replaced System.Exit calls with getActivity.finishAffinity() in the below 2 files

NewPipe/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
src/main/java/org/schabi/newpipe/ExitActivity.java

Fixes the following issue(s)

• Fixes Replace the System.exit calls with getActivity.finishAffinity() #6428

APK testing

I ran the APK on an emulator and went through the settings flow and ensured that my changes persisted after the importing task had finished and the app was restarted.

Due diligence

• I read the contribution guidelines.

[triallax]

Thanks for making a PR! Please avoid putting the issue number in the PR title.

[triallax]

Note that the "APK testing" section is for putting a link to the APK (from the "Checks" tab of the PR; the APK isn't there currently because you're a first-time contributor so a maintainer has to manually approve the checks to be run), not for how you tested it yourself.

[danielmbutler]

Apologies for "Apk Testing" section I will remember this in future :)

[Stypox]

Thank you!

[triallax]

LGTM, just a bunch of minor nits.

[XiangRongLin]

Can you also rewrite the commit messages to have a short summary with less than 70 characters followed by an optinal body with further descriptions/explanations.

If you look at the commits on github, you can see that they are cut off. https://github.com/TeamNewPipe/NewPipe/pull/6495/commits

[Redirion]

@XiangRongLin I think we can just squash the commits when we merge this and add our own summary, so no worries there

[XiangRongLin]

That would need to be done by him, because otherwise i think it counts the contribution towards the one squashing and merging it and not the PR opener

[Redirion]

oh I just noticed, the context param is not required. Activity and FragmentActivity(returned from requireActivity) are derived from Context

java.lang.Object
↳ | android.content.Context
  | ↳ | android.content.ContextWrapper
  |   | ↳ | android.view.ContextThemeWrapper
  |   |   | ↳ | android.app.Activity

java.lang.Object
↳ | android.content.Context
  | ↳ | android.content.ContextWrapper
  |   | ↳ | android.view.ContextThemeWrapper
  |   |   | ↳ | android.app.Activity
  |   |   |   | ↳ | androidx.activity.ComponentActivity
  |   |   |   |   | ↳ | androidx.fragment.app.FragmentActivity

[Redirion]

lgtm

[danielmbutler]

let me know if all is good then I will squash the commit messages.

[Redirion]

yes, all good, go ahead please

[danielmbutler]

Should be sorted now

[XiangRongLin]

@Stypox @mhmdanas You two have to approve it, because you requested changes

[Redirion]

I still see 9 commits. Looks like the squashing did not work. Can you try again @danielmbutler ?

[danielmbutler]

Hi Guys I've been trying to squash my previous commits but it seems to merge them all together and then commit the merge on top of previous commits, not sure what I'm doing wrong

[danielmbutler]

After multiple tries, I figured it out lol

[Stypox]

Perfect, thank you!