-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved metadata layout, better tags accessibility #6463
Conversation
People asking for this feature said it suits them, so I'd consider this PR ready for review :-) |
Please add before / after screenshots (it should be systematic when changing UI) |
@B0pol You mean this should be added to the template? "Please add before/after screenshots when changing the UI of the app." |
I meant systematic as in not even for newpipe but for all software contributions. |
Here is a screenshot @B0pol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Will be merged after 0.21.6 is released
What is it?
Description of the changes in your PR
96dp
. I don't know why I chose a percentage in the first place, since using a constant width works better in any layout (e.g. on tablets or TVs).Fixes the following issue(s)
Fixes #6459
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence