Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved metadata layout, better tags accessibility #6463

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jun 9, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Instead of using a percentage of the screen width, I now set the tag label width to 96dp. I don't know why I chose a percentage in the first place, since using a constant width works better in any layout (e.g. on tablets or TVs).
  • Tags are now placed at the bottom of the description tab, with a centered TAGS label and a full visible list of tags, as requested in A better ui for tags in description #6459.

Fixes the following issue(s)

Fixes #6459

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Stypox Stypox mentioned this pull request Jun 9, 2021
3 tasks
@TobiGr TobiGr added the GUI Issue is related to the graphical user interface label Jun 9, 2021
@Stypox
Copy link
Member Author

Stypox commented Jun 18, 2021

People asking for this feature said it suits them, so I'd consider this PR ready for review :-)

@skyGtm
Copy link

skyGtm commented Jun 18, 2021

#6459 (comment)

@B0pol
Copy link
Member

B0pol commented Jun 20, 2021

Please add before / after screenshots (it should be systematic when changing UI)

@opusforlife2
Copy link
Collaborator

it should be systematic when changing UI

@B0pol You mean this should be added to the template? "Please add before/after screenshots when changing the UI of the app."

@B0pol
Copy link
Member

B0pol commented Jun 20, 2021

it should be systematic when changing UI

@B0pol You mean this should be added to the template? "Please add before/after screenshots when changing the UI of the app."

I meant systematic as in not even for newpipe but for all software contributions.
Adding it to the template is a good idea 👍

@Stypox
Copy link
Member Author

Stypox commented Jul 4, 2021

Here is a screenshot @B0pol

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Will be merged after 0.21.6 is released

@TobiGr TobiGr merged commit 96f5cd9 into TeamNewPipe:dev Jul 12, 2021
This was referenced Aug 4, 2021
@Stypox Stypox deleted the metadata-tags branch August 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A better ui for tags in description
5 participants