-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase buffer for playback after rebuffer #6444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Let's wait for feedback from the people in the original issue
Make it an even 10000ms, I say! “ψ(`∇´)ψ |
@Slicer32 @nzimas @SmoothJaz @XNUConner @castrik @bibin-v2020 @Flam3z @snsgnq could you test if this APK (from the CI) fixes your buffering issues? (I pinged you since you commented in #6425) |
So far so good... Just started testing with new apk.. |
Just downloaded the apk and testing out a handful of videos. Issue seems to be fixed :) |
Sorry for the late reply, i have tried the newpipe increasebuffer after apk and thankfully it works wonders...very smooth indeed! Will notify if I encounter any issues..so far good job guys |
Yes!! fine now. I can see considerable difference on buffering! It's smooth like never before.. Thanks |
Will the fix be added with v21.4? I can see it's already released but I didn't see about 'buffer' in the latest blog post. |
Bit late to this party but I haven't had any issue so far with this apk! |
@bibin-v2020 rhe latest blog post was released before this was merged |
👍 |
@SmoothJaz A little heads-up: when you quote a text block that contains mentions of other users in it, those people get notifications all over again. Try to avoid that. |
@opusforlife2 oops, how embarrassing! |
I just installed V0.21.5 yesterday and hoped the buffering issue would've been resolved but I just noticed it again. It is still about half a second until it buffers again. For me it doesn't always happen, often force-closing the app or deleting the cache helps for some hours. |
seems like this fix an issue with download, like if we try to download multiple video by navigating next and next, some times it stuck with download option and show "Force Close" or "Wait", but now it seems working smoothly, I will update if any issues related to this. Thanks for your affort |
Hi, in the last month i experienced this issue several times. |
What is it?
Description of the changes in your PR
NewPipe used a very small/short buffer of just 500ms to fill after a buffer depletion. Some devices seem to have issues with that and get in a loop of draining this buffer and having to refill it again leading to a short buffering every 500ms.
From ExoPlayer doc:
The default duration of media that must be buffered for playback to resume after a rebuffer, in milliseconds. A rebuffer is defined to be caused by buffer depletion rather than a user action
We are using ExoPlayer's default value now which is 5000ms.
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence