Use constraint layout for play queue item #6443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR uses the contraint layout in play queue item to improve how it looks, in particular on small devices (see screenshots below). The item became a little bit bigger, but that's just because the thumbnail now is really
16:9(its height was squished, before). I also removed the "selected" indicator that was present to the left of the item a few versions ago (added in b0948cf): its icon did not exist so it was invisible, and anyway I don't think it was any useful, since changing the color of the playing item is already enough to distinguish it from the others.Before:
After:
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
I tested both on API 19 and on Android 10 and everything works as expected.
Due diligence