Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PrettyTime to 5.0.1 #6414

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Jun 1, 2021

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

Upgrade PrettyTime to 5.0.1, which fixes a minor mistake in the Romanian translations and adds the Somali language, among other things.

They also updated the README to state that PrettyTime 5 requires Java 8. I'm not sure if this affects NewPipe (as everything has been working fine before), but I thought I'd point it out.

Fixes the following issue(s)

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/2886740373/artifacts/64612759

Due diligence

@nadiration @iamthesenate1 can you test this?

@triallax triallax added the localisation / translation Everything that has to do with translations or Weblate label Jun 1, 2021
@B0pol
Copy link
Member

B0pol commented Jun 2, 2021

It doesn't affect newpipe because we're already using Java 8

NewPipe/app/build.gradle

Lines 74 to 81 in ffad244

compileOptions {
// Flag to enable support for the new language APIs
coreLibraryDesugaringEnabled true
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
encoding 'utf-8'
}

Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Redirion Redirion merged commit ef6d0cc into TeamNewPipe:dev Jun 2, 2021
@triallax triallax deleted the upgrade-prettytime-5.0.1 branch June 2, 2021 12:48
This was referenced Jun 5, 2021
@iamthesenate1
Copy link
Contributor

Hi! Sorry for answering so late but yes, I tested with the 0.21.4 RC and the translation is now correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettytime update In Romanian translation 1 minute is wrongly translated [localisation/translation]
4 participants