Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve setting import and export paths #6402

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented May 31, 2021

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

  • Set ImportExportDataPath only on successful export
  • Set ImportExportDataPath only on successful import
  • Commit path immediately when import backup

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
https://github.com/TeamNewPipe/NewPipe/suites/2872990922/artifacts/64206682

Due diligence

@XiangRongLin XiangRongLin added the bug Issue is related to a bug label May 31, 2021
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
One small thing: please annotate the parameters as @Nonnull

@triallax
Copy link
Contributor

@cubetronic could you please test this PR?

@XiangRongLin
Copy link
Collaborator Author

One small thing: please annotate the parameters as @Nonnull

Done

@Redirion
Copy link
Member

Redirion commented Jun 2, 2021

could we take the opportunity and replace the System.exit calls with getActivity.finishAffinity() and launch of the main activity?

so

System.exit(0);

to

`getActivity().finishAffinity();
startActivity(getActivity().getPackageManager().getLaunchIntentForPackage(getActivity().getPackageName()));

@XiangRongLin
Copy link
Collaborator Author

could we take the opportunity and replace the System.exit calls with getActivity.finishAffinity() and launch of the main activity?

@Redirion I don't see a reason for why it would NEED to be done here together. Since you already know what those methods do, you could open a seperate PR for that.

@TobiGr TobiGr changed the title Save backup bug Fix and improve setting import and export paths Jun 4, 2021
@TobiGr TobiGr merged commit db2e03e into TeamNewPipe:dev Jun 4, 2021
@XiangRongLin XiangRongLin deleted the save_backup_bug branch June 5, 2021 04:56
This was referenced Jun 5, 2021
Stypox added a commit to Stypox/NewPipe that referenced this pull request Jun 6, 2021
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
Stypox added a commit to Stypox/NewPipe that referenced this pull request Jun 6, 2021
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
@Stypox Stypox mentioned this pull request Jun 6, 2021
14 tasks
Stypox added a commit to Stypox/NewPipe that referenced this pull request Jun 8, 2021
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to navigate internal storage to export database
4 participants