-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve setting import and export paths #6402
Conversation
Also set the folder instead of the file itself as path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One small thing: please annotate the parameters as @Nonnull
@cubetronic could you please test this PR? |
Done |
could we take the opportunity and replace the System.exit calls with getActivity.finishAffinity() and launch of the main activity? so
to `getActivity().finishAffinity(); |
@Redirion I don't see a reason for why it would NEED to be done here together. Since you already know what those methods do, you could open a seperate PR for that. |
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
https://github.com/TeamNewPipe/NewPipe/suites/2872990922/artifacts/64206682
Due diligence