Test and clean up PlayQueue #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imericxu
force-pushed
the
test-and-update-playqueue
branch
from
0660a49
to
fe8b253
Compare
AudricV
added
the
codequality
imericxu
force-pushed
the
test-and-update-playqueue
branch
from
50d802b
to
bf270d4
Compare
imericxu
force-pushed
the
test-and-update-playqueue
branch
from
ebf5237
to
89423a8
Compare
app/src/test/java/org/schabi/newpipe/player/playqueue/PlayQueueTest.java
Outdated
Show resolved
Hide resolved
app/src/test/java/org/schabi/newpipe/player/playqueue/PlayQueueTest.java
Outdated
Show resolved
Hide resolved
app/src/test/java/org/schabi/newpipe/player/playqueue/PlayQueueTest.java
Outdated
Show resolved
Hide resolved
|
Other than that it looks good to go for me |
- Remove multiple casts of obj - Simply use object equals on the streams because PlayQueueItem’s equals already compares urls
Assignments that don't require the constructor can be moved out.
Original did not cover the case of when streams is empty and documentation does not specify any input restrictions. There's an ambiguity with broadcasting an event between the documentation and the actual code (see TODO).
PlayQueueItem overrides equals and hashCode, so using indexOf is perfectly fine.
Final fields should be arranged first
Stops Android Studio from "recognizing" them as tests
- Add early return for invalid sizes to shuffle - Rename variables to be more descriptive - Refactor moving list element, removing unnecessary operations - Unwrap if clause for adding to history because the condition is guaranteed by the guard clause - Inline the value 0 for the ReorderEvent - Update documentation to reflect new changes
After testing the app, I realized that shuffling a queue with size 2 does nothing
imericxu
force-pushed
the
test-and-update-playqueue
branch
from
188f651
to
40f6697
Compare
|
I noticed that the |
Does not affect Gradle tests and only benefits IDE workflow
But aren't the spies used in every test? What i know of is, that the first tests always takes the longest, because it gets all the overhead of initializing stuff |
XiangRongLin
approved these changes
May 25, 2021
|
@TobiGr Should this be squashed before merging? On one hand, it's 20 commits, on the other hand, some of them do have usefull messages that may be worth keeping |
|
No complaints means no problems 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
setIndex(int): voidAPK testing
On the website, the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence