Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Room to 2.3.0. #6313

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update Room to the stable 2.3.0 release.
  • Convert Converters to a Kotlin object.

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label May 16, 2021
@Redirion
Copy link
Member

thanks for the update but what improvement does "Convert Converters to a Kotlin object." do? I don't think it is directly related to this dependency update and I also don't see any improvement over the java object. But maybe I am missing it as I am not familiar with Kotlin.

@Stypox
Copy link
Member

Stypox commented Jun 9, 2021

@Isira-Seneviratne

@Isira-Seneviratne
Copy link
Member Author

Yeah, the conversion to Kotlin was mostly to make the code a bit simpler, and Room 2.3 introduced support for Kotlin objects as converters.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good, thank you :-)

@Stypox Stypox merged commit 06d10cf into TeamNewPipe:dev Jun 9, 2021
This was referenced Jun 26, 2021
@Isira-Seneviratne Isira-Seneviratne deleted the Update_Room_to_2.3.0 branch July 15, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants