Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black drawables in night themes in share dialog (RouterActivity) #6151

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Apr 23, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • use themed context in share dialog when getting the dialog drawables
  • use white fill color in night theme for a few drawables

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Apr 23, 2021
@TobiGr TobiGr mentioned this pull request Apr 23, 2021
3 tasks
@TobiGr TobiGr changed the base branch from dev to release_0.21.2 April 25, 2021 09:37
@TobiGr TobiGr merged commit bacb35f into release_0.21.2 Apr 26, 2021
@TobiGr TobiGr deleted the share-dialog-color branch April 26, 2021 09:51
@TobiGr TobiGr restored the share-dialog-color branch April 26, 2021 09:52
@TobiGr TobiGr deleted the share-dialog-color branch April 26, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant