Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException: Attempt to get length of null array in MainActivity #5999

Merged
merged 8 commits into from
Apr 6, 2021

Conversation

wangear
Copy link
Contributor

@wangear wangear commented Apr 4, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

issue : TeamNewPipe#5096
changed :
- rollback dp->sp.
- If additional textView is overlapped, only title view shows.
issue : TeamNewPipe#5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.
issue : TeamNewPipe#5096
changed :
- remove unusable variable
@wangear wangear closed this Apr 4, 2021
@wangear wangear reopened this Apr 4, 2021
…chabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to get length of null array TeamNewPipe#5996

issue : TeamNewPipe#5996
changed :
- Checked null
@AudricV AudricV changed the title Fix 5996 Fix NullPointerException: Attempt to get length of null array in MainActivity Apr 4, 2021
@AudricV AudricV added the bug Issue is related to a bug label Apr 4, 2021
Copy link
Contributor

@tch69 tch69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked just fine

Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thank you

@Redirion Redirion merged commit 5d5f8b4 into TeamNewPipe:dev Apr 6, 2021
@wangear wangear deleted the fix_5996 branch April 6, 2021 12:37
This was referenced Apr 11, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
…Activity (TeamNewPipe/NewPipe#5999)

* Fixed Unable to start activity ComponentInfo{org.schabi.newpipe/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to get length of null array TeamNewPipe/NewPipe#5996
issue : TeamNewPipe/NewPipe#5996
changed :
- Checked null
spvkgn pushed a commit to spvkgn/NewPipe that referenced this pull request Jun 5, 2021
…Activity (TeamNewPipe#5999)

* Fixed Unable to start activity ComponentInfo{org.schabi.newpipe/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to get length of null array TeamNewPipe#5996
issue : TeamNewPipe#5996
changed :
- Checked null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
4 participants