Fix display of channel details when it has no videos

[sauravrao637]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• in ChannelFragment.java do not throw emptyStateView error if no videos are present as there will be header in list which shows channel metadata and thus should be visible to user as expected by issue fix, also when there is no video the playlistController is hidden to prevent the app crash

• showEmptySpace() hides all the views in list including header when there is some error so it should be not called when there is header in the list, so changes are done accordingly in BaseListInfoFragment.java

Fixes the following issue(s)

• Fixes Can't subscribe to channels without videos #5959

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

• I read the contribution guidelines.

[triallax]

Thanks for opening a PR! Please try to make your PR title more descriptive next time. Instead of "Fixes #ISSUE," instead put the issue itself. For example, see the edited title.

[XiangRongLin]

@cybersphinx @sauravrao637 Can one of you provide a channel link where that is the case

[sauravrao637]

@cybersphinx @sauravrao637 Can one of you provide a channel link where that is the case

Yeah Sure here it is .
:)
or you can search "no videos channel" and filter by channel and browse one with no video

[peat80]

https://www.youtube.com/channel/UC4_2gEWKp78sE7MJMIqAZLQ

Try this one. 😀

Fix works also for channels with no items on other services it seems. 👍

[sauravrao637]

@mhmdanas Hi, I am waiting for review please update soon :)

[XiangRongLin]

@sauravrao637 I can't reproduce the behaviour described in the issue with your provided channel on v0.20.10

[TobiGr]

Thank you. Works for me. Please re-add the empty lines to increase readability.

[TobiGr]

@XiangRongLin that's interesting. It must be a regression introduced in 0.21.0. 0.20.11 works, too.

I guess that was caused by #5148

[XiangRongLin]

@XiangRongLin that's interesting. It must be a regression introduced in 0.21.0. 0.20.11 works, too.

I guess that was caused by #5148

I can't read... i somehow read 0.21.0 in the issue as 0.20.10

I was already wondering if i should update my app, when i couldn't reproduce it.

[sauravrao637]

I've done the required changes :)
Please have a look

[sauravrao637]

@sauravrao637 I can't reproduce the behaviour described in the issue with your provided channel on v0.20.10

Try with this onehttps://www.youtube.com/channel/UCo0rk6fLb2V4SqBQwNBFuDA

[XiangRongLin]

@mhmdanas You need to remove your "Changes Requested" status before this can be merged. Otherwise the button is not clickeable

[triallax]

@XiangRongLin done.

[XiangRongLin]

@sauravrao637 Can you squash it down to a single commit with the message set to the PR message. If i do it, the contributation may not show up on your profile.

[sauravrao637]

@XiangRongLin , I did it after so many attempts :) but the message is "squash" :(

[XiangRongLin]

@sauravrao637 try this one https://www.git-tower.com/learn/git/faq/edit-fix-commit-message/