Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WebViewClientCompat. #5217

Merged
merged 2 commits into from
Dec 19, 2020
Merged

Use WebViewClientCompat. #5217

merged 2 commits into from
Dec 19, 2020

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use WebViewClientCompat in ReCaptchaActivity.

APK testing

debug.zip

Due diligence

Stypox
Stypox approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. The debug apk size is bigger by 36922 bytes and the release by 7406 bytes, @TobiGr do you consider it a good tradeoff? In that case merge ;-)

@TobiGr
Copy link
Member

TobiGr commented Dec 19, 2020

7kB difference is ok

@TobiGr TobiGr merged commit 467dacd into TeamNewPipe:dev Dec 19, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_WebViewClientCompat branch December 19, 2020 10:52
This was referenced Dec 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isira-Seneviratne @TobiGr @Stypox