Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ContextCompat.getDataDir(). #5176

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Use ContextCompat.getDataDir(). #5176

merged 1 commit into from
Dec 15, 2020

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Dec 15, 2020 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use ContextCompat.getDataDir() to retrieve the app data directory.

APK testing

debug.zip

Due diligence

Stypox
Stypox approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. Thank you!

@Stypox Stypox merged commit 480348f into TeamNewPipe:dev Dec 15, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_ContextCompat_getDataDir branch December 15, 2020 08:50
XiangRongLin added a commit to XiangRongLin/NewPipe that referenced this pull request Dec 15, 2020
@XiangRongLin
Fix compile error caused by auto merging
2c93aef 
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
@XiangRongLin XiangRongLin mentioned this pull request Dec 15, 2020
Merged
4 tasks
XiangRongLin added a commit to XiangRongLin/NewPipe that referenced this pull request Dec 15, 2020
@XiangRongLin
Fix compile error caused by auto merging
a772337 
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
This was referenced Dec 21, 2020
Closed
Merged
spvkgn pushed a commit to spvkgn/NewPipe that referenced this pull request Aug 4, 2021
@XiangRongLin @spvkgn
Fix compile error caused by auto merging
4340dac 
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @Stypox