Fix respecting brightness-volume-gesture settings #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
template missing
Stypox
approved these changes
Nov 20, 2020
|
Wrong debug apk |
Yeah, I built it myself in order to test |
|
@B0pol I guess you refer to the package name which is not matching, don't you? I changed the branch name shortly before opening the PR and apparently used the old one. I'll build the apk when the PR post is finished next time ;) |
|
No, it was an apk dated of September, with crash because of youtube changes |
|
Hmm, that's weird. I downloaded the provided zip and the creation date of the apk is 2020-11-20 21:11 (CET). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR fixes the issue that the player didn't respected the brightness/volume gesture setting. When disabling one of them while the other is enabled should change the value for the whole screen instead of just disable the display portion. I didn't know of this behavior :`)
I also moved the
isBrightnessEnabledandisVolumeEnabledto the actualonScroll-callback. If a stream is opened or playing and you'll change one or both toggle states the setting won't be applied for this openedFragment(checked on 0.20.2).Fixes the following issue(s)
APK testing
app-debug.zip
Due diligence