-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use view binding in activities. #4762
Use view binding in activities. #4762
Conversation
for me work , some bug fixed , perfect i get only 1 error |
This comment has been minimized.
This comment has been minimized.
@Disqu3-mirOir-qt that error is not related to the contents of this PR |
fbd2162
to
6d89b22
Compare
f4047de
to
56d971d
Compare
d88be91
to
5cce950
Compare
5cce950
to
bbcc8f0
Compare
@TobiGr I'd like to merge this as soon as possible, otherwise @Isira-Seneviratne will be overwhelmed by rebasing. I will review and test tomorrow. |
26f53ba
to
6e2a276
Compare
@Stypox It's been updated. Merging time! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, thank you! I tested on API 19 and on Android 7.0 and everything worked well. Could someone else review, before merging, though? I have no experience with view binding ;-) @TacoTheDank @TobiGr @vkay94
I have a little bit of experience with it. Did a quick test on my Android 10 device and everything seems to work as it should. Nice job Isira! |
I checked the "id moving" (discussed here in another view binding PR: #5029 (comment)), but it should be fine since the Id isn't used in the code :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Code looks good to me. I could not find any bugs on Android 4..4, 5.0, 9 and 11 while testeing various scenarios.
It looks like @Stypox - how dare you :P - caused a merge conflict. Can you rebase one last time, please?
d6121c8
6e2a276
to
d6121c8
Compare
Lol stop torturing this poor guy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again! :-D
What is it?
Description of the changes in your PR
APK testing
debug.zip
Due diligence