Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display meta info about search query, stream creator or topic #4754

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Nov 1, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add support for displaying stream and search query meta info. Can be disabled in the content settings.

Fixes the following issue(s)

Closes #4614

Relies on the following changes

TeamNewPipe/NewPipeExtractor#451

APK testing

app-debug.zip

Due diligence

@TobiGr TobiGr added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Nov 1, 2020
@opusforlife2
Copy link
Collaborator

What happened to the code which would automatically name zips and the included apks according to the branch name?

@opusforlife2
Copy link
Collaborator

The Learn More link for COVID-19 takes you to https://webcache.googleusercontent.com/search?q=cache:< your health ministry website here >

Do we really want users to use this link?

@TobiGr
Copy link
Member Author

TobiGr commented Dec 15, 2020

Webcache URL is not used anymore and links to non-google information are shown.

@Stypox
Copy link
Member

Stypox commented Dec 20, 2020

Improved layout @TobiGr @B0pol app-debug.zip

@TobiGr
Copy link
Member Author

TobiGr commented Dec 20, 2020

Code changes look perfect. So do the UI changes.

This was referenced Dec 21, 2020
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also merge this

@TobiGr TobiGr merged commit 84d1792 into dev Dec 23, 2020
@TobiGr TobiGr deleted the meta_info branch December 23, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display YouTube's "fake news" warnings and infoboxes
3 participants