check if the JSON MimeType is supported #12356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShareASmile
added
bug
|
app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionFragment.kt
Outdated
Show resolved
Hide resolved
ShareASmile
added
the
ready for review
ShareASmile
removed
the
ready for review
11 tasks
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Jul 27, 2025
…ting-oldandroid check if the JSON MimeType is supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
If no JSON MIME type is available on the android(old version), use "application/octet-stream" instead, which targets json files one puts on the old device.
Another solution could be to check for
Build.VERSION.SDK_INT < Build.VERSION_CODES.Qinstead of using the webkit MimeTypesSince a file of type application/json can still be created locally(by exporting as such), the mime type for the file picker might need to be */* to support both locally exported(as "application/json") and otherwise transferred .json files("application/octet-stream").
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence