Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added daggerhilt for better dependency injection for Compose Viewmodels #11399

Closed

Conversation

braiso-22
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Aug 4, 2024
@AudricV AudricV added the template ignored The user didn't follow the template/instructions (or removed them) label Aug 5, 2024
@acrodemocide
Copy link

Is there an issue associated with this PR? I think the template needs to be filled out.

@braiso-22
Copy link
Author

Sorry, I made the PR by mistake, I'm currently working on converting a configuration screen to Compose and this was one of the commits.

@braiso-22 braiso-22 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small PRs with less than 50 changed lines template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants