ServiceHelper improvements #10741
Open
ServiceHelper improvements #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There wase one place where `null` was not checked. We use the fallback function there. For the `name` function we make clear that `"<unknown>"` is returned iff the service is not known.
Profpatsch
force-pushed
the
improve-service-id-fetching
branch
from
27ff20d
to
e352b4c
Compare
Instead of going through the Service ID, we provide some more specific wrappers to discourage passing service IDs around.
Profpatsch
force-pushed
the
improve-service-id-fetching
branch
from
7ae6381
to
a3355cd
Compare
|
AudricV
added
the
codequality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a possible NullPointerException & improves function names
What is it?
Due diligence