Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "free memory" check before downloading [Android N / API 24+] #10505

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Added "free memory" check before downloading [Android N / API 24+] #10505

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13b0e4f
Added "free space" check before downloading, eliminates all bug relat…
CloudyRowly Oct 22, 2023
14ffc95
Fixed Gradle dependency error with NewPipe Extractor
CloudyRowly Oct 28, 2023
5762da2
Added toast message duration
CloudyRowly Mar 20, 2024
0821adc
Apply suggestions from code review
CloudyRowly Mar 20, 2024
4d759ae
Merge branch 'dev' into fix-download-failure-handling-bug
CloudyRowly Mar 20, 2024
4897280
removed unused methods
CloudyRowly Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added toast message duration 
Provides users time to react to visual changes

Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
  • Loading branch information
@CloudyRowly @TobiGr
CloudyRowly and TobiGr committed Mar 20, 2024
commit 5762da2dbd1eb0f8262b737840b4a97d797d4182
2 changes: 1 addition & 1 deletion app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ private void prepareSelectedDownload() {
freeSpace = mainStorage.getFreeMemory();
if (freeSpace <= size) {
Toast.makeText(context, getString(R.
string.error_insufficient_storage), Toast.LENGTH_SHORT).show();
string.error_insufficient_storage), Toast.LENGTH_LONG).show();
// move the user to storage setting tab
final Intent storageSettingsIntent = new Intent(Settings.
ACTION_INTERNAL_STORAGE_SETTINGS);
Expand Down