Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast forward/backward on long press video sides #8461

Open
5 tasks done
ThigSchuch opened this issue May 30, 2022 · 12 comments
Open
5 tasks done

Fast forward/backward on long press video sides #8461

ThigSchuch opened this issue May 30, 2022 · 12 comments
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)

Comments

@ThigSchuch
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Use the same behavior of Telegram's video player when you long press right for fast forward or left for fast backward.
Video speeds changes to 2x.

video_2022-05-30_18-40-46.mp4

Why do you want this feature?

  1. It's more precise when you jump 10~20 seconds and want go backward just a few seconds.
  2. You can fast forward but still can see what is happening, and don't want change speed and reset speed many times.

Additional information

No response

@ThigSchuch ThigSchuch added the feature request Issue is related to a feature in the app label May 30, 2022
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented May 31, 2022

All users wouldn't want the same speed or every single frame while fast forwarding. You might use this method instead.

  1. Click on 1x or Playback Speed Controls on the right of top bar of interface.
  2. Check Fast forward during silence.

Now you can mute the video and fast forward easily.

IMG_20220531_080951

@ThigSchuch
Copy link
Author

Not the same thing and as I said, too much steps to fast forward/backward.

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented May 31, 2022

This option stays saved for muted playback once you click OK on speed controls. From then on, just turn down the volume to zero by gesture or Mute button for fast forwarding easily.

@ThigSchuch
Copy link
Author

Just tried your method.
Video doesn't fast forward when you mute it or set volume to zero.
Also, and when you don't want to skip silent?
Again, many steps or adding steps to something not directly related.

The idea is simple:
Fast forward / backward at speed of 2x ~ 3x ~ 4x (I don't know witch is better, but set one speed, user don't need to select it) when long pressing right / left.

Usually I use this option when I want to skip ads that perhaps will be useful, as example, I don't really want to hear it, but I want to see what is happening.
Or maybe watching a stream, you don't care much what is happening, but still want to see it, to not loose something.

@DominikNovosel
Copy link

This might be a useful option among the gesture control settings in Video and Audio→Behavior and seems like a good way to achieve more precise seeking for shorter timespans.

I don't know witch is better, but set one speed, user don't need to select it

Since the user is already given the option to adjust the "double tap" seek interval, we might as well let them adjust the fast-forward/rewind rate achieved using this method (let's call it hold-scrub for brevity) as well.

We also need to make sure that double-tap seek and hold-scrub will work together without interfering with each other and that either one can be disabled in the settings by the user.
It also seems like hold-scrub could easily be triggered by accident, which would be very annoying. This can be fixed by adding a prerequisite to its operation, such as having to have the player HUD pulled up. I don't use Telegram, but as far as I can tell from the video, that's how it's implemented there.

@ThigSchuch
Copy link
Author

1_4965355203495724845.mp4

More details at Telegram.
Their fast forward works like New Pipe, only works if you tap on edges, they have a space in the middle that works for play/pause or zoom.

I need to open the video to use the shortcuts, but independently if it is in full-screen or not, I can use them.

@opusforlife2 opusforlife2 added the player Issues related to any player (main, popup and background) label Jun 11, 2022
@litetex litetex added the niche Only relevant to a very small amount of people label Jun 19, 2022
@jstetten
Copy link

jstetten commented Jul 24, 2022

This would be an incredibly useful feature. On small screens, the real estate for double tapping (let alone many, many more) left or right is already extremely cramped as it is, made even narrower still for those with Android side-swiping gestures enabled. Scrubbing can be even less precise, especially on long videos (not to mention that the scrub thumbnail does not always display for me).

Wouldn't the obvious solution to reduce accidental triggering of the proposed feature be to have a it only be triggered after

  • a double (triple?) tap
  • a long-press delay

or both combined?

Also, there's no need to display every frame, right? Skipping ahead/behind the set skip time each iteration would be plenty enough.

Cheers for listening.

@opusforlife2
Copy link
Collaborator

On small screens, the real estate for double tapping (let alone many, many more) left or right is already extremely cramped as it is,

How small are we talking? It's fine on a 4.6" screen for me.

@DominikNovosel
Copy link

DominikNovosel commented Jul 28, 2022

Wouldn't the obvious solution to reduce accidental triggering of the proposed feature be to have a it only be triggered after

Oh, you poor, sweet, innocent child. There almost certainly isn't such a thing as an obvious solution in UI design. 🤣 Let me explain.

I'm assuming we want these player controls to be interoperable and unobtrusive, or as I said:

We also need to make sure that double-tap seek and hold-scrub will work together without interfering with each other and that either one can be disabled in the settings by the user.

That way, users who are already used to the existing controls don't have to readjust and those that want to use both are... actually able to do that. That being said, regarding your suggestions:

  • a double (triple?) tap

This would interfere with the double-tap seek functionality and, if implemented, would cause the video to skip forward by 10 seconds (or whatever you might have it set to) before actually starting to hold-scrub, so... no.

  • a long-press delay

I'm not quite sure what you mean by this, but assuming this entails hold→delay→start fast-forwarding/rewinding, that seems like a good option, but users may feel annoyed that they have to wait before something actually happens and it may not actually prevent accidental triggering since the delay would have to be fine tuned to account for a bunch of different scenarios while still being usable. Thus, I suggest the following: tap→hold→start fast-forwarding/rewinding. I can't speak for anyone else, but in my experience, i don't tend to accidentally double-tap, so this shouldn't be any different and should still feel responsive and snappy, but other suggestions are welcome. It might actually be best to let the user decide on this in the settings too in a dropdown such as
Hold-scrub mode (description: Fast forward or rewind by holding your finger on either side of the screen. Disabled when set to None.):

  • None (default)
  • Hold
  • Tap then hold
  • Hold (when the player UI is visible)

Going forward, we're probably going to need a shorter way to describe sequences of gestures. To this end, I propose the following:

swipe - ↑ ↓ → ← (let's hope we won't need that)
tap - .
hold - _
delay - , (doesn't count as a gesture and doesn't interrupt the preceding gesture)
start fast-forwarding/rewinding - ¤
eg. ._,¤

Also, there's no need to display every frame, right? Skipping ahead/behind the set skip time each iteration would be plenty enough.

I could be wrong, but it seems as though you misunderstood the actual purpose of the proposed feature. It's intended to function somewhat like a VCR; you can intuitively fast-forward or rewind without missing what's happening in the meantime. This necessitates displaying most, if not all frames. What you seem to be describing already exists in NewPipe; you double-tap on either side of the screen which immediately skips backward or forward by a set interval. From what I understood, you have trouble double-tapping on small screens and want an alternative gesture for this purpose. However, once again, it would be ideal for the double-tap seek and hold-scrub to coexist. Accessibility is still important, so I'd love to hear possible solutions.

@DominikNovosel
Copy link

Just checking in, is there still interest for implementing this feature?

@gabriel-berardi
Copy link

YouTube seems to have incorporated this feature in their app, and it works really well. I would like to have the same feature in NewPipe.

@D4n2021

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

8 participants