Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort local playlists in groups / folders #1313

Open
justanidea opened this issue Apr 14, 2018 · 33 comments
Open

Sort local playlists in groups / folders #1313

justanidea opened this issue Apr 14, 2018 · 33 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app

Comments

@justanidea
Copy link
Contributor

It could be cool to sort our local playlist, because when you have a lot of it its kinda messy.
If someone would like to do that, I would advise him/her not to do folders, but things more like the animation used for "import export" in the sub page for each new category created by the user.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@TobiGr TobiGr removed the stale label Jul 19, 2019
@Stypox Stypox added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Jul 21, 2019
@Stypox
Copy link
Member

Stypox commented Sep 4, 2019

Related (with discussion): #1982 (comment)

@MD77MD
Copy link

MD77MD commented Aug 27, 2020

@Stypox #1313 (comment)... although I'm a fan of tags...I agree with you, folders make more sense here and alot easier to use too.

This would help organize all my playlist.. a special folder for all my music 🎶 playlists... I can even have it divided by artist, now that's cool 😎

@justanidea
Copy link
Contributor Author

Damn, the me of 2 years ago had such a good idea :o And @MD77MD is on the same direction as me, i was thinking in sorting my musics too when writing this post (i usually get 1000 more musics each year...)

@MD77MD

This comment was marked as off-topic.

@cntrl-s
Copy link

cntrl-s commented Jan 15, 2021

@Stypox @MD77MD
is someone working on this?

i want to try to implement this

@Stypox
Copy link
Member

Stypox commented Jan 15, 2021

@cntrl-s No, nobody is working on this at the moment, so feel free to pick it up! Thank you :-D
Before taking ui / usability design decisions I suggest you to get some feedback here, so that you won't have to make more changes later ;-)

@cntrl-s
Copy link

cntrl-s commented Jan 15, 2021

@Stypox

Before taking ui / usability design decisions I suggest you to get some feedback here, so that you won't have to make more changes later ;-)

i will, thank you :)

@MD77MD
Copy link

MD77MD commented Jan 25, 2021

@cntrl-s any update?

i don't know coding but I can help with testing and feedback.

@cntrl-s
Copy link

cntrl-s commented Jan 26, 2021

@MD77MD i am new to android development so this will take a while

i will let you know once i have something for you to test :P

@cntrl-s
Copy link

cntrl-s commented Jan 26, 2021

@MD77MD @Stypox how do you think we should implement playlist group view

i am thinking horizontally scrollable (like feed group) under playlist tab with thumbnail of first playlist under the group as thumbnail for the group

@XiangRongLin
Copy link
Collaborator

@cntrl-s I would do it like the channel groups/subscription groups.
So the current playlist view gets expanded by a header to manage the groups. When clicking on one of those groups it opens the old playlist overview with all the playlists in that group. From there you can open a single playlist to see the single videos.

It would allow to reuse/copy stuff, depending if you want to extract out common components or just copy over what you need. Restriction would be that you can only have 1 layer and thus can't have nested groups, like a traditional file system.
But i dare say that multilayer approach is a lot harder and not necessary.

@cntrl-s
Copy link

cntrl-s commented Jan 26, 2021

But i dare say that multilayer approach is a lot harder and not necessary.

@XiangRongLin i agree with this, i was thinking we could have simple groups like subscription groups

@tsilvs
Copy link

tsilvs commented Jan 26, 2021

JSON / YAML import / export of playlists feature would also be nice.

And maybe an archiving feature per playlist?

Guess I'll describe these ideas in separate issues, but they should be considered in possible playlists tab redesign.

@Stypox
Copy link
Member

Stypox commented Jan 27, 2021

i agree with this, i was thinking we could have simple groups like subscription groups

@cntrl-s I also agree, but I'd use the group's thumbnail as a background image for the group item. Also, I'd make the playlist group items have: a height that is something in between 1.5x and 2x the height of subscription group items; a width/height ratio of 16:9.

Guess I'll describe these ideas in separate issues,

@JeffRockatansky yeah, those are different and unrelated proposals

@cntrl-s
Copy link

cntrl-s commented Jan 27, 2021

@cntrl-s I also agree, but I'd use the group's thumbnail as a background image for the group item.

@Stypox that's what i said in a reply above we could use the thumbnail of the first playlist under the group as thumbnail for the group or we could combine different playlists thumbnail to make a new one (vlc android does this for folder with multiple videos)

@Stypox
Copy link
Member

Stypox commented Jan 27, 2021

@cntrl-s if this does not require storing too much cached data on the user's phone then ok

@cntrl-s
Copy link

cntrl-s commented Jan 27, 2021

@Stypox ok i will start working on this, thank you

@Stypox
Copy link
Member

Stypox commented Jan 27, 2021

@cntrl-s thanks to you! :-D

@cntrl-s
Copy link

cntrl-s commented Feb 20, 2021

@JeffRockatansky @Stypox @MD77MD @XiangRongLin how do you think the playlist selection view should be when selecting playlists for a group

should every playlist have a radio button or have a ':white_check_mark:' on top of selected playlists or something else

@XiangRongLin
Copy link
Collaborator

I personally don't care too much about it. Try to make it simple and close to the existing channel groups.

So a list where if one entry is selected the thumbnail is covered my a ✔,would be the simplest that i can think of right now

@tsilvs
Copy link

tsilvs commented Feb 24, 2021

@cntrl-s a tick over a playlist is good. Radio will take too much additional space. You could even dim selected list elements in addition to a check mark.

Maybe you could also try implementing paths while naming a playlist? E.g. when you type Parent/Child or Parent.Child (or with any other custom delimiter) then playlist Child is moved into playlist Parent, so the tree could look like this:

Parent
├ Child
│ └ [videos]
└ [videos]

Parsing existing names would also be very much appreciated, especially because my playlists all look like _sw.os.linux.arch, _sci.phys.quant etc, and I have over 100 playlists already)))

In case of parsing a path, you should also consider and process certain delimiter edge cases:

  • leading, e.g. /Parent/Child
  • trailing, e.g. Parent/Child/
  • neighboring, e.g. Parent//Child

@XiangRongLin
Copy link
Collaborator

@JeffRockatansky Im going to give this a hard NO, because this is complex enough as is.

Please open a seperate issue if you want the feature.

@tsilvs
Copy link

tsilvs commented Feb 24, 2021

@XiangRongLin ok, I get it.

What about the structure of folders itself?

Should a folder contain:

  • both videos and sublists
    or
  • only sublists?

@XiangRongLin
Copy link
Collaborator

#1313 (comment)

@tsilvs
Copy link

tsilvs commented Feb 24, 2021

@XiangRongLin could you explain in detail why multilayer is harder? And why do you think it's not necessary?

@XiangRongLin
Copy link
Collaborator

@XiangRongLin could you explain in detail why multilayer is harder? And why do you think it's not necessary?

Because its multiple layers, meaning more stuff to do. More changes need to be made to the data model, the logic and the representation. More needs to be tested and more code needs to be reviewed. Overall its more work, which can be split up into multiple feature request and multiple PR

@cntrl-s
Copy link

cntrl-s commented Feb 25, 2021

@JeffRockatansky i will implement it with dim and a tick

@cntrl-s
Copy link

cntrl-s commented Feb 25, 2021

Because its multiple layers, meaning more stuff to do. More changes need to be made to the data model, the logic and the representation. More needs to be tested and more code needs to be reviewed. Overall its more work, which can be split up into multiple feature request and multiple PR

also we have to keep track of both local and remote playlists within the folder structure which would be very complex to design database for and this would be even harder as sqlite doesn't support constraints on the database table, we probably would have to keep track of local and remote playlists separately

@Sam4000der3
Copy link

I'm still hope for this feature. I have to much playlists. I hope to filter my playlists by genre (music playlists) and language.

@MD77MD
Copy link

MD77MD commented Sep 13, 2022

any luck with this?

@Sam4000der3
Copy link

any luck with this?

Noop. Unfortunately not

@RohitSingh107
Copy link

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app
Projects
None yet
Development

No branches or pull requests

10 participants