Create mutable bitmap copy if needed.

TeamNewPipe · Aug 6, 2022 · 34e1e94 · 34e1e94
1 parent 40c7afd
commit 34e1e94
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/app/src/main/java/org/schabi/newpipe/util/PicassoHelper.java b/app/src/main/java/org/schabi/newpipe/util/PicassoHelper.java
@@ -134,17 +134,20 @@ public Bitmap transform(final Bitmap source) {
                                         .getDimension(R.dimen.player_notification_thumbnail_width),
                                 source.getWidth());
 
-                        final Bitmap result = BitmapCompat.createScaledBitmap(
+                        Bitmap result = BitmapCompat.createScaledBitmap(
                                 source,
                                 (int) notificationThumbnailWidth,
                                 (int) (source.getHeight()
                                         / (source.getWidth() / notificationThumbnailWidth)),
                                 null,
                                 true);
 
-                        if (result != source) {
-                            source.recycle();
+                        // create a new mutable bitmap to prevent strange crashes on some devices
+                        // (see #4638)
+                        if (!result.isMutable()) {
+                            result = result.copy(result.getConfig(), true);
                         }
+                        source.recycle();
                         return result;
                     }