Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【バグ】Privateなリポジトリでプラグインがダウンロードできない。 #73

Closed
PeyaPeyaPeyang opened this issue Apr 2, 2022 · 0 comments · Fixed by #76
Closed

【バグ】Privateなリポジトリでプラグインがダウンロードできない。 #73

PeyaPeyaPeyang opened this issue Apr 2, 2022 · 0 comments · Fixed by #76
Assignees
@PeyaPeyaPeyang
Labels
Priority: Critical Status: Resolved Type: Bug

Comments

@PeyaPeyaPeyang
Copy link
Member

詳細

title

再現方法

  1. Private repoをつくる
  2. /kpm i叩く

期待される動作

正常にインストールされる

TeamKUNPluginManager のバージョン

v2.8.2

サーバーの詳細

Paper 1.16.5

その他

直し方(メモ)

  • developブランチの047748ceで新規ブランチを切る
  • 047748ceの版におけるCommandRegister.java#L68のURLのscopeパラメタに、repoスコープを付ける
  • stableに割り込みマージしてリリース
  • developに取り込み

↑要調査

  • ざっと調べた感じ、GitHubにはPrivate repositoryの読み取り権限がないっぽいのでひとつ上のrepoで暫定対応
@PeyaPeyaPeyang PeyaPeyaPeyang self-assigned this Apr 2, 2022
PeyaPeyaPeyang added a commit that referenced this issue Apr 7, 2022
@PeyaPeyaPeyang
fix: *.github.comでTokenを送りつける。
2b2ae86 
Closes #73
PeyaPeyaPeyang added a commit that referenced this issue Apr 7, 2022
@PeyaPeyaPeyang
fix: *.github.comでTokenを送りつける。
5ad9430 
Closes #73
@PeyaPeyaPeyang PeyaPeyaPeyang mentioned this issue Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeyaPeyaPeyang PeyaPeyaPeyang

Labels
Priority: Critical Status: Resolved Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*.github.comでTokenを送りつける。 TeamKun/TeamKUNPluginManager
1 participant
@PeyaPeyaPeyang