Allow for Nans in input of Permutation Importance #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
===========================================
- Coverage 97.32% 80.58% -16.75%
===========================================
Files 49 49
Lines 3142 3142
Branches 585 585
===========================================
- Hits 3058 2532 -526
- Misses 44 569 +525
- Partials 40 41 +1
|
|
This PR is ready for review |
lopuhin
reviewed
Jun 10, 2020
There was a problem hiding this comment.
Thanks @Matgrb PR looks great 👍
But for that I would also need to increase sklearn version in the requirements to at least 0.20.
Yes makes sense, it would need to be updated in setup.py and requirements.txt, and also we'd need to adjust or remove py36-legacy in tox.ini
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
===========================================
- Coverage 97.32% 80.58% -16.75%
===========================================
Files 49 49
Lines 3142 3142
Branches 585 585
===========================================
- Hits 3058 2532 -526
- Misses 44 569 +525
- Partials 40 41 +1
|
|
Hi @lopuhin , sorry for the delay. I have implemented the suggestions from your comment. |
|
Thanks you! This were merged in eli5-org/eli5#2 and released to PyPI with v0.11 |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
===========================================
- Coverage 97.32% 80.58% -16.75%
===========================================
Files 49 49
Lines 3142 3142
Branches 585 585
===========================================
- Hits 3058 2532 -526
- Misses 44 569 +525
- Partials 40 41 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
So far i used
force_all_finite=False, but even better would be force_all_finite='allow-nan'. But for that I would also need to increase sklearn version in the requirements to at least 0.20.