Skip to content

Comments

Implement Pattern module#47

Merged
masa10-f merged 33 commits intomasterfrom
pattern
Jun 2, 2025
Merged

Implement Pattern module#47
masa10-f merged 33 commits intomasterfrom
pattern

Conversation

@masa10-f
Copy link
Collaborator

Before submitting, please check the following:

  • Make sure you have tests for the new code and that test passes (run pytest)
  • If applicable, add a line to the [unreleased] part of CHANGELOG.md, following keep-a-changelog.
  • Format added code by ruff
  • Type checking by mypy and pyright
  • Make sure the checks (github actions) pass.
  • Check that the docs compile without errors (run make html in ./docs/ - you may need to install dependency for sphinx docs, see docs/requirements.txt.)

Implemented pattern module, which contains two pattern classes and helper functions.

Then, please fill in below:

Context (if applicable):

Description of the change:

Related issue:

@masa10-f masa10-f requested a review from Copilot May 12, 2025 13:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the new pattern module with two pattern classes and accompanying helper functions while updating tests and documentation.

  • Adds tests for MutablePattern covering initialization, command addition (including error cases), and space calculations.
  • Updates documentation to include references and detailed module docs for the new pattern module.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/test_pattern.py Added tests to validate the functionality of the new MutablePattern methods.
docs/source/references.rst Updated the module reference list to include the new pattern module.
docs/source/pattern.rst Added documentation for pattern module classes and helper functions using autodoc.
Comments suppressed due to low confidence (1)

tests/test_pattern.py:58

  • [nitpick] Consider removing the main invocation of pytest; tests are usually executed via the pytest CLI, which can help avoid unintended side effects.
    pytest.main()

@masa10-f masa10-f mentioned this pull request May 3, 2025
@masa10-f
Copy link
Collaborator Author

Memo: I should update the pattern check rules

@masa10-f masa10-f marked this pull request as ready for review May 23, 2025 13:55
@masa10-f masa10-f requested review from EarlMilktea and d1ssk May 23, 2025 13:56
@masa10-f masa10-f requested a review from EarlMilktea June 1, 2025 05:18
@masa10-f masa10-f requested a review from EarlMilktea June 2, 2025 11:53
@masa10-f masa10-f merged commit 5bb3501 into master Jun 2, 2025
20 checks passed
@masa10-f masa10-f deleted the pattern branch June 2, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants