Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new pattern module with two pattern classes and accompanying helper functions while updating tests and documentation.
- Adds tests for MutablePattern covering initialization, command addition (including error cases), and space calculations.
- Updates documentation to include references and detailed module docs for the new pattern module.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_pattern.py | Added tests to validate the functionality of the new MutablePattern methods. |
| docs/source/references.rst | Updated the module reference list to include the new pattern module. |
| docs/source/pattern.rst | Added documentation for pattern module classes and helper functions using autodoc. |
Comments suppressed due to low confidence (1)
tests/test_pattern.py:58
- [nitpick] Consider removing the main invocation of pytest; tests are usually executed via the pytest CLI, which can help avoid unintended side effects.
pytest.main()
Closed
Collaborator
Author
|
Memo: I should update the pattern check rules |
EarlMilktea
requested changes
May 23, 2025
EarlMilktea
requested changes
Jun 1, 2025
EarlMilktea
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting, please check the following:
pytest)ruffmypyandpyrightmake htmlin./docs/- you may need to install dependency for sphinx docs, seedocs/requirements.txt.)Implemented
patternmodule, which contains two pattern classes and helper functions.Then, please fill in below:
Context (if applicable):
Description of the change:
Related issue: