Merged
Conversation
Closed
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- docs/source/graphstate.rst: Language not supported
- docs/source/references.rst: Language not supported
Comments suppressed due to low confidence (1)
tests/test_graphstate.py:44
- Consider using a more specific exception type (e.g., ValueError) when testing for duplicate nodes to maintain consistency with similar error cases in the file.
with pytest.raises(Exception, match="Node already exists"):
Collaborator
Author
|
@nabe98 I have slightly modified the API from the mf branch, so please comment on this PR if any. I will implement visualizer and improve append method later. |
Collaborator
Author
memo: I'll add this when the visualizer is implemented |
masa10-f
commented
Apr 21, 2025
Collaborator
Author
masa10-f
left a comment
There was a problem hiding this comment.
memo: Local Cliffords can be removed from pattern layer if I properly design canonical form of graphstate.
EarlMilktea
reviewed
Apr 22, 2025
Collaborator
Author
|
I also replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting, please check the following:
pytest)ruffmypyandpyrightmake htmlin./docs/- you may need to install dependency for sphinx docs, seedocs/requirements.txt.)Then, please fill in below:
Description of the change:
Implement GraphState, which provides an interface to design graph state and measurement in MBQC.
Close #33