Skip to content

Comments

Setup repository#12

Merged
masa10-f merged 49 commits intomasterfrom
setup-github-configs
Feb 27, 2025
Merged

Setup repository#12
masa10-f merged 49 commits intomasterfrom
setup-github-configs

Conversation

@masa10-f
Copy link
Collaborator

@masa10-f masa10-f commented Feb 17, 2025

This PR aims to set up GitHub workflows, templates for issues, and PRs.

  • Issue and PR templates
  • Setup Github Workflows
    • ruff
    • pytest
    • type-checking(mypy, pyright)
    • dependabot
    • codecov(?)
  • changelog

I also added common.py to check the workflows.

@masa10-f
Copy link
Collaborator Author

Codecov seems complicated to introduce so that I will treat it as another issue.

@masa10-f masa10-f self-assigned this Feb 18, 2025
@masa10-f masa10-f changed the title [WIP]Setup repository Setup repository Feb 18, 2025
@masa10-f masa10-f mentioned this pull request Feb 18, 2025
@masa10-f masa10-f requested review from EarlMilktea and shinich1 and removed request for shinich1 February 18, 2025 11:56
@shinich1
Copy link
Contributor

@shinich1 The number of reviewers is currently limited. Do you know how to increase the limit?

seems like only public repos can have multiple reviewers on PRs. If you're ready for it, let's make this public!

Copy link
Contributor

@shinich1 shinich1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@masa10-f
Copy link
Collaborator Author

seems like only public repos can have multiple reviewers on PRs. If you're ready for it, let's make this public!

@shinich1 Thanks! I’d like to make it public soon after this PR is merged.

@shinich1
Copy link
Contributor

seems like only public repos can have multiple reviewers on PRs. If you're ready for it, let's make this public!

@shinich1 Thanks! I’d like to make it public soon after this PR is merged.

In fact, it seems the CI quota for private repo has been reached and we need to wait until 1st of March to run further CIs. I suggest we make this repo public now, to enable CIs? I guess if we wrap this PR up quickly there's not much difference whether we make public before or after.

@masa10-f
Copy link
Collaborator Author

@shinich1 You're right! Could you make this repository open since I don't have permission to do so?

@masa10-f masa10-f merged commit 2758de4 into master Feb 27, 2025
17 checks passed
@masa10-f masa10-f deleted the setup-github-configs branch February 27, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants