Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-merge workflow #22

Merged
merged 3 commits into from
Mar 15, 2025
Merged

Fix auto-merge workflow #22

merged 3 commits into from
Mar 15, 2025

Conversation

masa10-f
Copy link
Collaborator

@masa10-f masa10-f commented Mar 10, 2025

Before submitting, please check the following:

  • Make sure you have tests for the new code and that test passes (run pytest)
  • If applicable, add a line to the [unreleased] part of CHANGELOG.md, following keep-a-changelog.
  • Format added code by ruff
  • Type checking by mypy and pyright
  • Make sure the checks (github actions) pass.
  • Check that the docs compile without errors (run make html in ./docs/ - you may need to install dependency for sphinx docs, see docs/requirements.txt.)

Then, please fill in below:

Description of the change:

  • Fixed the branch name in dependabot-auto-merge.yml, which enables auto-mege of PR opened by the dependabot
  • Explicitly specified the PR_URL

@masa10-f masa10-f self-assigned this Mar 10, 2025
@masa10-f masa10-f marked this pull request as draft March 10, 2025 01:13
@masa10-f masa10-f marked this pull request as ready for review March 10, 2025 03:18
@shinich1
Copy link

Are you sure about auto merge? There was a case where I had to modify dependabot's PR before safely merging due to breaking changes in dependencies (pyzx, numpy).

@masa10-f
Copy link
Collaborator Author

@shinich1
--auto mode will merge if and only if all the CIs are passed according to the document. Therefore, we will probably be able to modify depandabot's PR if necessary

@masa10-f masa10-f merged commit 3ec6d7f into master Mar 15, 2025
18 checks passed
@masa10-f masa10-f deleted the enable-auto-merge branch March 15, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants