Skip to content

feat: add dynamic sound system#572

Open
TakeABao23 wants to merge 86 commits into
TeamGalacticraft:mainfrom
TakeABao23:Sound-Rework
Open

feat: add dynamic sound system#572
TakeABao23 wants to merge 86 commits into
TeamGalacticraft:mainfrom
TakeABao23:Sound-Rework

Conversation

@TakeABao23
Copy link
Copy Markdown

@TakeABao23 TakeABao23 commented Apr 29, 2026

I have added a dynamic sound system and some new sound instance classes in order to facilitate the further creation of custom sounds for GC5. Every machine in the game has this functionality, though only electric-powered machines have sounds assigned to them.

(Note: This is a re-upload of an older pull request. Since the original pull request, I moved my workspace to a separate branch for cleanliness and implemented all the requested changes from the original.)

Sound System Features:

  • A sound manager that handles custom looping GC5 sounds
  • A generic machine sound class
  • State change tracking
  • State change sound modulation (fading in and out)

Machine Sounds Features:

  • Unique sound that plays when the machine is powered
  • Unique sound that plays when the machine is active
  • Circuit scritch sounds play randomly as the Circuit Fabricator runs
  • Separate (currently empty) map of sounds for coal-powered machines

Feedback sought:

  • Volume: how loud are single machines? Groups of machines?
  • Quality: do they sound like what they're supposed to?
  • Performance: does this system hurt performance in any way?

Known issues:

  • Upon relogging, sounds won't play until the machine status updates

Future Plans:

  • Add more unique sounds (particularly for coal-powered machines)
  • possible unique sound behaviors for different states?

TakeABao23 and others added 30 commits January 22, 2026 09:45
feat: added machine sound handling through MachineSoundInstance class
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/MachineSound.java Outdated
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/MachineSound.java Outdated
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/MachineSound.java
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/MachineSound.java
Comment thread src/main/resources/assets/galacticraft/sounds.json
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/MachineSound.java Outdated
Comment thread src/main/resources/assets/galacticraft/sounds.json Outdated
Comment thread src/main/resources/assets/galacticraft/sounds.json Outdated
Comment thread src/main/resources/assets/galacticraft/sounds.json Outdated
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/GCSoundManager.java Outdated
Comment thread src/main/java/dev/galacticraft/mod/client/sounds/GCSoundMap.java
TakeABao23 and others added 5 commits May 6, 2026 17:06
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
@TakeABao23 TakeABao23 requested a review from Roelymole May 7, 2026 00:07
@TakeABao23
Copy link
Copy Markdown
Author

Ah it appears it won't build because it's using the MachineLib version that hasn't been committed yet

@TakeABao23
Copy link
Copy Markdown
Author

Is there anything left with this before it could be merged?

Comment thread src/main/java/dev/galacticraft/mod/client/sounds/GCSoundMap.java Outdated
@TakeABao23 TakeABao23 requested a review from Roelymole June 3, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants