feat: add dynamic sound system#572
Open
TakeABao23 wants to merge 86 commits into
Open
Conversation
This reverts commit a9258a5.
feat: added machine sound handling through MachineSoundInstance class
Roelymole
reviewed
May 4, 2026
Roelymole
reviewed
May 6, 2026
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
Author
|
Ah it appears it won't build because it's using the MachineLib version that hasn't been committed yet |
Author
|
Is there anything left with this before it could be merged? |
Roelymole
reviewed
Jun 3, 2026
Co-authored-by: Roelymole <161453965+Roelymole@users.noreply.github.com>
…raft into Sound-Rework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a dynamic sound system and some new sound instance classes in order to facilitate the further creation of custom sounds for GC5. Every machine in the game has this functionality, though only electric-powered machines have sounds assigned to them.
(Note: This is a re-upload of an older pull request. Since the original pull request, I moved my workspace to a separate branch for cleanliness and implemented all the requested changes from the original.)
Sound System Features:
Machine Sounds Features:
Feedback sought:
Known issues:
Future Plans: