"Race advancements" and "Global statistics" are functional#564
Open
Youraveragebub wants to merge 9 commits into
Open
"Race advancements" and "Global statistics" are functional#564Youraveragebub wants to merge 9 commits into
Youraveragebub wants to merge 9 commits into
Conversation
You can even hide yourself from these statistics that are visible server wide. You can compete in teams to see who has the most advancements completed (although atm there is no reward for it, just a flex). Global statistics are server wide statistics similar to vanilla but only for galacticraft stats. It is a leaderboard type system too (which you can hide yourself from) and the "server" tab shows all the advancements completed by the server as a whole. It shows you the first 3 players to complete an advancement.
Author
|
I haven't tested the "teams" tab in global stats btw so let me know if I gotta do something about it because idk how to test it now. |
Roelymole
requested changes
Apr 14, 2026
Member
Roelymole
left a comment
Roelymole
left a comment
There was a problem hiding this comment.
This is looking good, but I am concerned that the information it is showing needs to be more focused on the space race.
Some refactoring of the SpaceRaceScreen.java file is in order before I can give more specific feedback about most of that.
I ordered as many of those imports as I could. (I hope there aren't any that slipped through and I doubt there will be) I added a config file for the categories of the Server stats (formerly global stats). There is NO defaults, however everything is in # basically quick suggestions if you want to add or remove anything. Translations should (hopefully) be in place. Buttons scaling with GUI is now implemented. Moved the text down by one pixel (line 55 SpaceRaceButton.java) Last but not least I added a bunch of files with decent names so you can easily look through it. Also wildcard imports and my intellij don't work together for SOME reason.
src\main\java\dev\galacticraft\impl\network\GCApiServerPacketReceivers.java
(again because I can't read)
It now reads from codec backed JSON files for the default values. Also have split up the spaceracescreen.java into multiple files.
Maybe done? Race Adv and server stats screens both contain code exactly for those tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can even hide yourself from these statistics that are visible server wide. You can compete in teams to see who has the most advancements completed (although atm there is no reward for it, just a flex). Global statistics are server wide statistics similar to vanilla but only for galacticraft stats. It is a leaderboard type system too (which you can hide yourself from) and the "server" tab shows all the advancements completed by the server as a whole. It shows you the first 3 players to complete an advancement.