feat: Meteor Structure Generation#436
Open
maxryan008 wants to merge 4 commits into
Open
Conversation
simple meteor crater spawning
Meteors now have layers and cores of any blocks that can be set in data generation. Probably going to need a rewrite anyway however due to making meteors structures instead of features because of size constaints
Meteors are now structures. Generation seems... decent. Lots of values will need adjusting and generation of meteors needs improving
made meteor structures generate with each chunk being its own part. should multithread well i believe? i think minecraft can multithread the chunk loading? dont quote me.... updated license
maxryan008
changed the title
Member
|
You should really be following the conventional commits conventions for commit messages and pull request titles. |
Roelymole
changed the title
Contributor
Author
|
See I didnt even know there was conventions.... |
Member
Did you not read the contributing guidelines! |
Contributor
Author
|
Briefly. I clearly missed that
…On Sat, 29 Mar 2025 at 12:02 pm, Roelymole ***@***.***> wrote:
See I didnt even know there was conventions....
Did you not read the contributing guidelines
<https://github.com/TeamGalacticraft/Galacticraft/blob/main/.github/CONTRIBUTING.md>
!
—
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILLSFQB5V6FWTNLR5MMWXD2WXPJTAVCNFSM6AAAAABZ6OZ5G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRSHE2TONBYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: Roelymole]*Roelymole* left a comment
(TeamGalacticraft/Galacticraft#436)
<#436 (comment)>
See I didnt even know there was conventions....
Did you not read the contributing guidelines
<https://github.com/TeamGalacticraft/Galacticraft/blob/main/.github/CONTRIBUTING.md>
!
—
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILLSFQB5V6FWTNLR5MMWXD2WXPJTAVCNFSM6AAAAABZ6OZ5G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRSHE2TONBYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding multiple types of meteor structures for world generation