Fix BlockNetworkManager.java failing to invalidate chunks properly#507
Merged
Fix BlockNetworkManager.java failing to invalidate chunks properly#507
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #505 where cables stop working after chunks are unloaded and reloaded. The root cause was that when chunks were purged, the networksByLevelBlockPos lookup table wasn't being cleaned up, leading to stale entries that prevented proper network rebuilding when chunks were reloaded.
Changes:
- Fixed
BlockNetworkManager.purgeChunk()to properly clean up thenetworksByLevelBlockPoslookup table when chunks are unloaded - Renamed
clearChunktopurgeChunkto better reflect its contract and added documentation - Added comprehensive test case that reproduces the bug and validates the fix
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SFMBlockNetworkChunkUnloadReproTests.java | New test that reproduces issue #505 by simulating chunk unload/reload and verifying network rebuilds correctly |
| WaterNetworkManager.java | Updated to call renamed purgeChunk method |
| CableNetworkManager.java | Updated to call renamed purgeChunk method |
| BlockNetworkManager.java | Fixed purgeChunk to properly clean up networksByLevelBlockPos entries and added defensive checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #505