Minor repairs #1438
Merged
Minor repairs #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed Options::OptionValue() to return correct value for option --USSN-kicks-override-Mandel-Muller - deprecated --scale-CHE-mass-loss-with-surface-helium-abundance in favour of --scale-mass-loss-with-surface-helium-abundance - removed option --scale-CHE-mass-loss-with-surface-helium-abundance from "BSEonly" vector in Options.h - changed "scale-CHE-mass-loss-with-surface-helium-abundance" to "--scale-mass-loss-with-surface-helium-abundance" in "RangeExcluded" vector in Options.h - version should have been "v03.27.00" instead of "v03.26.02" - change included new functionality. This version is "v03.27.01" to compensate.
✅ COMPAS Build Successful!
Detailed Evolution PlotClick to view evolution plotGenerated by COMPAS CI |
ilyamandel
approved these changes
Oct 27, 2025
Collaborator
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
Approved, but please check, because I changed Mandel-Muller to mandel-muller to be consistent with our capitalisation choices for other option names (e.g., --fryer-22-fmix, --maltsev-fallback, etc.)
✅ COMPAS Build Successful!
Detailed Evolution PlotClick to view evolution plotGenerated by COMPAS CI |
Collaborator
Author
|
All good - thanks @ilyamandel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect repairs:
changed Options::OptionValue() to return correct value for option --USSN-kicks-override-Mandel-Muller
deprecated --scale-CHE-mass-loss-with-surface-helium-abundance in favour of --scale-mass-loss-with-surface-helium-abundance
removed option --scale-CHE-mass-loss-with-surface-helium-abundance from "BSEonly" vector in Options.h
changed "scale-CHE-mass-loss-with-surface-helium-abundance" to "--scale-mass-loss-with-surface-helium-abundance" in "RangeExcluded" vector in Options.h
version should have been "v03.27.00" instead of "v03.26.02" - change included new functionality. This version is "v03.27.01" to compensate.