Skip to content

Conversation

@reinhold-willcox
Copy link
Collaborator

Added the components of the velocity vector for a given star to possible output, as requested by @TomWagg

@reinhold-willcox
Copy link
Collaborator Author

reinhold-willcox commented Jun 30, 2025

These output variables are not included by default. To access them without modifying the source code, you should use the logfile-definitions option:

COMPAS --logfile-def LOGFILE.txt

=== LOGFILE.txt ===
 BSE_SNE_REC += {
     SUPERNOVA_PROPERTY::VELOCITY_X,
     SUPERNOVA_PROPERTY::VELOCITY_Y,
     SUPERNOVA_PROPERTY::VELOCITY_Z,
     COMPANION_PROPERTY::VELOCITY_X,
     COMPANION_PROPERTY::VELOCITY_Y,
     COMPANION_PROPERTY::VELOCITY_Z,
 }

Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reinhold-willcox !

But I am not a huge fan of calling it SPEED_X, etc. Elsewhere in the outputs, we always use VELOCITY for 3-d vectors and speed for scalars. Can we retain that for consistency?

@reinhold-willcox
Copy link
Collaborator Author

@ilyamandel Fixed

Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reinhold-willcox

@ilyamandel ilyamandel merged commit 88415fb into dev Jun 30, 2025
3 checks passed
@ilyamandel ilyamandel deleted the print_final_velocity_components branch June 30, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants