Add guard against invalid port numbers passed into NetCopyConnectionInfo #4380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
requested review from
VishalNehra,
EmmanuelMess,
VishnuSanal and
Copilot
VishnuSanal
previously approved these changes
Apr 14, 2025
VishnuSanal
added
the
PR-Awaiting-Final-Review
Must be 1..65535
EmmanuelMess
requested changes
May 1, 2025
| it[7].toInt() | ||
| } else { | ||
| LOGGER.warn("Port number is out of range: ${it[7]}") | ||
| 0 |
There was a problem hiding this comment.
Shouldn't this return the default port for ssh? I would think that returning 0 would just crash whatever uses this value?
There was a problem hiding this comment.
I prefer this to be the responsibility of downstream code - here is for just the regex extraction magic.
There was a problem hiding this comment.
Sorry for the delay. The type looks like it doesn't have any error state. port: Int should probably be port: Int? and be set to null on these cases, so that users know that the port could be "broken/unset".
| } | ||
| } catch (e: NumberFormatException) { | ||
| LOGGER.warn("Unable to parse port number: ${it[7]}", e) | ||
| 0 |
There was a problem hiding this comment.
Same here. It should be downstream code's responsibility of determining the default port number of different protocols.
EmmanuelMess
added
PR-Requested-Changes
VishalNehra
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add guard against invalid Integers as port number passed into NetCopyConnectionInfo.
Issue tracker
Fixes #4362
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck