Skip to content

Conversation

TranceLove
Copy link
Collaborator

Description

To fix possibility of opening SMB connection causing Amaze to crash, due to AgNO3/jcifs-ng#342

Upstream has fixes pushed to jcifs-ng 2.1.10.

Manual tests

  • Done

  • Device: Pixel 3 emulator

  • OS: Android 9

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

To fix possibility of opening SMB connection causing Amaze to crash, due to AgNO3/jcifs-ng#342
Copy link
Member

@EmmanuelMess EmmanuelMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hope no regressions are present in the library for this version

@VishnuSanal VishnuSanal added the PR-Awaiting-Final-Review this PR is awaiting a final review/approval label Apr 14, 2025
@VishnuSanal VishnuSanal merged commit 581ebed into release/4.0 Apr 14, 2025
4 checks passed
@VishnuSanal VishnuSanal mentioned this pull request Apr 14, 2025
4 tasks
@EmmanuelMess EmmanuelMess deleted the bugfix/jcifs-2.1.10 branch April 18, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Awaiting-Final-Review this PR is awaiting a final review/approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants