Fix -1 passed as index

[EmmanuelMess]

Fix index = -1 here:

AmazeFileManager/app/src/main/java/com/amaze/filemanager/adapters/RecyclerAdapter.java

Lines 180 to 183 in bed5d13

	if (itemsDigested.size() <= position || position < 0) {
	AppConfig.toast(context, R.string.operation_not_supported);
	return;
	}

Related #2303

[yasin459]

sorry, what is wrong here? I don't understand the problem
could you explain more, please?

[yasin459]

@EmmanuelMess
can you explain more?

[EmmanuelMess]

The problem is that in some cases the position is negative. That should never happen. There is code that makes the position be negative. We should find that code and fix it.

[yasin459]

@EmmanuelMess
I checked code occurrences and found 1 suspicious occurrence, one which is inside MainFragment and in onGlobalLayout and finally method loadViews, I think you get -1 because this method starts early while the holder is making calculations which is why it gives -1(no_position).
is it good if run a delayed thread?
like this:
new Handler().postDelayed(new Runnable() {

        @Override
        public void run() {
              loadViews();
        }
    }, 100);

instead of:
loadViews();

(I'm not sure about my answer though)

[EmmanuelMess]

checked code occurrences and found 1 suspicious occurrence, one which is inside MainFragment and in onGlobalLayout and finally method loadViews, I think you get -1 because this method starts early while the holder is making calculations which is why it gives -1(no_position).

   private void loadViews() {
    if (CURRENT_PATH != null) {
      if ((LIST_ELEMENTS == null || LIST_ELEMENTS.size() == 0) && !results) {
        loadlist(CURRENT_PATH, true, OpenMode.FILE);
      } else {
        reloadListElements(true, results, !IS_LIST);
      }
      if (selection) {
        for (Integer index : adapter.getCheckedItemsIndex()) {
          adapter.toggleChecked(index, null);
        }
      }
    } else {
      loadlist(home, true, OpenMode.FILE);
    }
  }

Do you mean to say that index is -1 in some iteration of the for (Integer index : adapter.getCheckedItemsIndex())?

  public ArrayList<Integer> getCheckedItemsIndex() {
    ArrayList<Integer> checked = new ArrayList<>();

    for (int i = 0; i < itemsDigested.size(); i++) {
      if (itemsDigested.get(i).getChecked() == ListItem.CHECKED) {
        checked.add(i);
      }
    }

    return checked;
  }

checked here has only Integers that are >=0 (i starts in 0 and is only incremented).

[EmmanuelMess]

The problem seems to be that MainFragment.onListItemClicked can be called with position NO_POSITION (as a result from vholder.getAdapterPosition()).

[EmmanuelMess]

Could you make some kind of callback after the item is actually selected? If not a delayed is ok, but only if you check that the position is not -1 after the delayed and alert the user (like:

    if (itemsDigested.size() <= position || position < 0) {
      AppConfig.toast(context, R.string.operation_not_supported);
      return;
    }

).