SCRUM-117 식당 주인은 사용자가 예약을 하면 해당 알림을 받을 수 있다 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. Walkthroughdevelop 브랜치용 CI/CD 워크플로우를 추가하고, 배포 스크립트를 도입했습니다. 알림 시스템을 도입하여 Kafka 소비자, 전송 추상화(Sendder), WebPush 구현, JPA 엔티티/리포지토리, 스키마 및 환경설정을 추가했습니다. WebPush 패키지를 notification 네임스페이스로 이동/정비하고 테스트를 경로 변경에 맞게 수정했습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant CI as dev-ci
participant CD as dev-cd
participant S as Deploy Script
Dev->>GH: push to develop / PR to develop
GH->>CI: Run dev-ci (build & test)
CI-->>GH: Test results
GH->>CD: Run dev-cd on push to develop
CD->>CD: Build bootJar, upload artifacts
CD->>S: Download artifacts & execute replace-new-version.sh
S->>S: Kill :8080, start app.jar (nohup) with profiles
S-->>CD: Deployment logs path
sequenceDiagram
autonumber
participant K as Kafka (topic: notification)
participant C as NotificationConsumer
participant ER as NotificationEnabledRepository
participant NS as NotificationSender
participant HR as NotificationHistoryRepository
participant WS as WebPushSender (Sender)
K-->>C: NotificationMessage
C->>ER: findByUserIdAndType(userId, type)
ER-->>C: List<NotificationEnabled>
C->>NS: send(message, enables)
loop for each enabled channel
NS->>HR: save(new NotificationHistory(userId))
NS->>WS: send(message) [if WS.isEnabled(channel)]
WS->>WS: Build payload
WS->>Repo: find subscriptions by user
alt subscriptions found
WS-->>WS: Send to each subscription
else no subscription
WS-->>WS: Throw / handle absence
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (36)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 Jira Ticket
SCRUM-117
🗣️ 리뷰 요구사항 (선택)
Summary by CodeRabbit